Hi Rob, Apologies for the delay. Was coordinating care for my parents who caught the COVID bug. Thanks, Badhri On Tue, Oct 13, 2020 at 6:50 AM Rob Herring <robh@xxxxxxxxxx> wrote: > > On Tue, Oct 13, 2020 at 8:43 AM Rob Herring <robh@xxxxxxxxxx> wrote: > > > > On Wed, Oct 7, 2020 at 7:43 PM Badhri Jagan Sridharan <badhri@xxxxxxxxxx> wrote: > > > > > > Hi Robb, > > > > > > Thanks for the reviews ! Responses inline. > > > > > > Regards, > > > Badhri > > > > > > On Mon, Oct 5, 2020 at 7:46 AM Rob Herring <robh@xxxxxxxxxx> wrote: > > > > > > > > On Mon, Sep 28, 2020 at 07:39:52PM -0700, Badhri Jagan Sridharan wrote: > > > > > Add device tree binding document for Maxim TCPCI based Type-C chip driver > > > > > > > > > > Signed-off-by: Badhri Jagan Sridharan <badhri@xxxxxxxxxx> > > > > > --- > > > > > Changes since v1: > > > > > - Changing patch version to v6 to fix version number confusion. > > > > > > > > > > Changes since v6: > > > > > - Migrated to yaml format. > > > > > > > > > > Changes since v7: > > > > > - Rebase on usb-next > > > > > > > > > > Changes since v8: > > > > > - Fix errors from make dt_binding_check as suggested by > > > > > Rob Herring. > > > > > --- > > > > > .../devicetree/bindings/usb/maxim,tcpci.yaml | 68 +++++++++++++++++++ > > > > > 1 file changed, 68 insertions(+) > > > > > create mode 100644 Documentation/devicetree/bindings/usb/maxim,tcpci.yaml > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/usb/maxim,tcpci.yaml b/Documentation/devicetree/bindings/usb/maxim,tcpci.yaml > > > > > new file mode 100644 > > > > > index 000000000000..f4b5f1a09b98 > > > > > --- /dev/null > > > > > +++ b/Documentation/devicetree/bindings/usb/maxim,tcpci.yaml > > > > > @@ -0,0 +1,68 @@ > > > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > > > +%YAML 1.2 > > > > > +--- > > > > > +$id: "http://devicetree.org/schemas/usb/maxim,tcpci.yaml#"; > > > > > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"; > > > > > + > > > > > +title: Maxim TCPCI Type-C PD controller DT bindings > > > > > + > > > > > +maintainers: > > > > > + - Badhri Jagan Sridharan <badhri@xxxxxxxxxx> > > > > > + > > > > > +description: Maxim TCPCI Type-C PD controller > > > > > + > > > > > +properties: > > > > > + compatible: > > > > > + enum: > > > > > + - maxim,tcpci > > > > > > > > Is there a datasheet for this? Searching for 'tcpci' doesn't really come > > > > up with anything other than this patch. Only chip I found is MAX77958. > > > > Bindings are for specific h/w devices. > > > > > > Unfortunately the datasheet cannot be made public yet. Has the datasheet > > > have to be made public before sending the bindings ? > > > > No, but we need a part number or some assurance that 'tcpci' is a specific part. Sure. Added the part number to the binding and changed the compatible string. Sending this as part of v11 > > I guess TCPCI is USB Type-C Port Controller Interface Specification. > > That's just a protocol definition, not a chip. DT describes h/w which > is more than just the protocol. > > Rob
