Re: [PATCH v2 2/2] ASoC: dt-bindings: renesas,rsnd: switch to yaml base Documentation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 23, 2020 at 9:40 PM Kuninori Morimoto
<kuninori.morimoto.gx@xxxxxxxxxxx> wrote:
>
>
> Hi Rob
>
> > > From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
> > >
> > > This patch switches from .txt base to .yaml base Document.
> > > It is still keeping detail explanations at .txt
> > >
> > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
> > > ---
> (snip)
> > > +  # For OF-graph
> > > +  port:
> > > +    description: OF-Graph subnode
> > > +    $ref: "audio-graph-card.yaml#/definitions/port"
> >
> > Something like this should work (at the top-level):
> >
> > allOf:
> >   - $ref: "audio-graph-card.yaml#
>
> Hmm.. it will be error, see below (A).
> How to solve it ??

All the 'allOf's have to be grouped.

> (I will keep to use above style)
>
> > > +# use patternProperties to avoid naming "xxx,yyy"
> > > +patternProperties:
> > > +  "^rcar_sound,dvc$":
> >
> > None of these are patterns.
>
> As always happen, "xxx,yyy" style will be error for me without patternProperties.
> What is wrong ??

Node names shouldn't really have vendor prefixes, but since you
already depend on this we shouldn't change that. We'll need to relax
the meta-schema, but for now it's fine as-is.

Rob



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux