On Fri, Oct 16, 2020 at 09:30:00AM -0500, Rob Herring wrote: > On Fri, Oct 16, 2020 at 2:11 AM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote: > > > > On Sat, Sep 19, 2020 at 11:39 PM Uwe Kleine-König > > <u.kleine-koenig@xxxxxxxxxxxxxx> wrote: > > > > > > When building with > > > > > > $ HOST_EXTRACFLAGS=-g make > > > > > > I do not think this is the intended usage > > of HOST_EXTRACFLAGS. > > Okay, but I looked at all the other instances of HOST_EXTRACFLAGS and > they do '+='. Are they all wrong? Hmm, I just tested that and indeed HOSTCFLAGS=-g make has the intended effect. Then the commit log is not optimal. I'd still say the patch is good even though the reasoning is now only aligning the assignment to others in the kernel tree. @Rob: Assuming you agree, do you throw out hte patch again and I resend with an improved commit log? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
