On Wed, Oct 14, 2020 at 04:29:41PM +0800, Shihlun Lin wrote: > Add DT binding schema for Advantech embedded controller AHC1EC0. Where's the driver? > > Signed-off-by: Shihlun Lin <shihlun.lin@xxxxxxxxxxxxxxxx> > --- > .../devicetree/bindings/mfd/ahc1ec0.yaml | 76 +++++++++++++++++++ > 1 file changed, 76 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/ahc1ec0.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/ahc1ec0.yaml b/Documentation/devicetree/bindings/mfd/ahc1ec0.yaml > new file mode 100644 > index 000000000000..2a3581d2ecab > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/ahc1ec0.yaml > @@ -0,0 +1,76 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +# All the top-level keys are standard json-schema keywords except for > +# 'maintainers' and 'select' Drop this. > + > + > +$id: http://devicetree.org/schemas/mfd/ahc1ec0.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Advantech Embedded Controller (AHC1EC0) > + > +maintainers: > + - Shihlun Lin <shihlun.lin@xxxxxxxxxxxxxxxx> > + - Campion Kang <campion.kang@xxxxxxxxxxxxxxxx> > + > +description: | > + AHC1EC0 is one of the embedded controllers used by Advantech to provide several > + functions such as watchdog, hwmon, brightness, etc. Advantech related applications > + can control the whole system via these functions. > + > + # In this case, a 'false' schema will never match. Drop > + > +properties: > + compatible: > + const: advantech,ahc1ec0 > + > + advantech,sub-dev-nb: > + description: > + The number of sub-devices specified in the platform. > + $ref: /schemas/types.yaml#/definitions/uint32 > + maxItems: 1 Isn't this just the length of the next property? > + > + advantech,sub-dev: > + description: > + A list of the sub-devices supported in the platform. Defines for the > + appropriate values can found in dt-bindings/mfd/ahc1ec0.h. > + $ref: "/schemas/types.yaml#/definitions/uint32-array" > + minItems: 1 > + maxItems: 6 This is kind of odd. Aren't you going to need DT info for each of the sub-dev. GPIO is a provider, backlight connection, LED properties, etc. > + > + advantech,hwmon-profile: > + description: > + The number of sub-devices specified in the platform. Defines for the > + hwmon profiles can found in dt-bindings/mfd/ahc1ec0. > + $ref: /schemas/types.yaml#/definitions/uint32 > + maxItems: 1 > + > +required: > + - compatible > + - advantech,sub-dev-nb > + - advantech,sub-dev > + > +if: > + properties: > + advantech,sub-dev: > + contains: > + const: AHC1EC0_SUBDEV_HWMON defines don't work here. > +then: > + required: > + - advantech,hwmon-profile > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/mfd/ahc1ec0.h> > + ahc1ec0 { > + compatible = "advantech,ahc1ec0"; > + > + advantech,sub-dev-nb = <2>; > + advantech,sub-dev = <AHC1EC0_SUBDEV_HWMON > + AHC1EC0_SUBDEV_WDT>; > + > + advantech,hwmon-profile = <AHC1EC0_HWMON_PRO_UNO2271G>; > + }; > -- > 2.17.1 >
