On Fri, Oct 16, 2020 at 05:43:08PM +0300, Andy Shevchenko wrote: > On Thu, Oct 15, 2020 at 3:33 PM Serge Semin <fancer.lancer@xxxxxxxxx> wrote: > > On Thu, Oct 15, 2020 at 11:59:03AM +0800, Jisheng Zhang wrote: > > > The compatible string is never used. > > > > Before sending v2 could you run "make dt_binding_check" for the DT schema > > modified in this patch? Like this: > > > > make -j8 ARCH=mips CROSS_COMPILE=mipsel-baikal-linux- dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml > > Do you really need to install all cross compilation tools for that? > I think it should simple work as > > % make dt_binding_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml Of course you don't. I just cited my normal command. Your version should be enough to perform the bindings file validation. Note that there are host tools/libs requirements, which need to be satisfied to make that command working. See the next file for details: Documentation/devicetree/writing-schema.rst -Sergey > > -- > With Best Regards, > Andy Shevchenko