On Thu, 15 Oct 2020 12:19:44 +0200, Enric Balletbo i Serra wrote: > Convert the soc/rockchip/power_domain.txt binding document to json-schema > and move to the power bindings directory. > > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx> > --- > Rob, I didn't add a number of clocks neither a number of pm_qos because will > be a finger in the air number. If you still want I add it, I can add a > number based on the actual users of this binding but no guarantee that > we don't need to change that number in the future. > > Changes in v4: > - Use hex for unit-addresses. > - Use space between compatibles in the example. > - Define child nodes for nested power domains even are duplicated but > more clear that adding a regex scaped to be a valid URI. > > Changes in v3: > - Fixed tab errors found by bot > > Changes in v2: > - Fixed a warning that says that 'syscon' should not be used alone. > - Use patternProperties to define a new level for power-domains. > - Add const values for power-domain-cells, address-cells, etc. > > .../power/rockchip,power-controller.yaml | 283 ++++++++++++++++++ > .../bindings/soc/rockchip/power_domain.txt | 136 --------- > 2 files changed, 283 insertions(+), 136 deletions(-) > create mode 100644 Documentation/devicetree/bindings/power/rockchip,power-controller.yaml > delete mode 100644 Documentation/devicetree/bindings/soc/rockchip/power_domain.txt > My bot found errors running 'make dt_binding_check' on your patch: ./Documentation/devicetree/bindings/power/rockchip,power-controller.yaml:61:13: [warning] wrong indentation: expected 10 but found 12 (indentation) ./Documentation/devicetree/bindings/power/rockchip,power-controller.yaml:106:17: [warning] wrong indentation: expected 14 but found 16 (indentation) ./Documentation/devicetree/bindings/power/rockchip,power-controller.yaml:138:21: [warning] wrong indentation: expected 18 but found 20 (indentation) See https://patchwork.ozlabs.org/patch/1382558 If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date: pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade Please check and re-submit.
