On Thu, Oct 15, 2020 at 4:25 PM Enric Balletbo i Serra
<enric.balletbo@xxxxxxxxxxxxx> wrote:
> On 15/10/20 8:52, Ricardo Cañuelo wrote:
> > On Wed, 2020-10-14 at 10:18 +0800, Tzung-Bi Shih wrote:
> >> The intermediate layer (i.e. codecs { ... }) breaks current code as
> >> you already discussed about that in previous threads:
> >> - of_platform_populate only creates immediate child devices.
> >> - the codec driver expects its parent is EC node.
> >
> > Thanks for your input, I'll try to address these issues in the drivers in v3.
> >
>
> Can you remind us which platforms support cros-ec-codec and why there is no an
> EC_FEATURE for that?
I failed to connect the question to this discussion thread.
But:
- Originally, MT8183 (arm64-based) chromebooks aimed to use
cros-ec-codec. However, we realized the RAM size is insufficient.
For some reason, the cros-ec-codec feature was not enabled.
- Currently, we have some AMD Picasso chromebooks that use cros-ec-codec.
- It used to have EC_FEATURE_AUDIO_CODEC. But I removed it in
https://patchwork.kernel.org/project/alsa-devel/patch/20191017213539.01.I374c311eaca0d47944a37b07acbe48fdb74f734d@changeid/.
Because we don't rely on the EC_FEATURE to do anything specifically.
As long as there is a corresponding node in DTS or ACPI table, the
cros-ec-codec gets probed.
