The definition "gpio_suffixes[] = { "gpios", "gpio" }" shows that both property names "cmd-gpios" and "cmd-gpio" are supported. But currently only "cmd-gpios" is allowed in this yaml, and the name used in mmp2-olpc-xo-1-75.dts is cmd-gpio. As a result, the following errors is reported. slave: 'cmd-gpios' is a required property slave: 'cmd-gpio' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Zhen Lei <thunder.leizhen@xxxxxxxxxx> --- Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml b/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml index b3c45c046ba5e37..dd549380a085709 100644 --- a/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml +++ b/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml @@ -24,15 +24,21 @@ properties: compatible: const: olpc,xo1.75-ec - cmd-gpios: + spi-cpha: true + +patternProperties: + "^cmd-gpio[s]?$": description: GPIO uspecifier of the CMD pin maxItems: 1 - spi-cpha: true - required: - compatible - - cmd-gpios + +oneOf: + - required: + - cmd-gpio + - required: + - cmd-gpios additionalProperties: false -- 1.8.3