Hi Fabrizio, On Tue, Oct 13, 2020 at 5:02 PM Fabrizio Castro <fabrizio.castro.jz@xxxxxxxxxxx> wrote: > Convert the Renesas DRIF bindings to DT schema and update > MAINTAINERS accordingly. > > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@xxxxxxxxxxx> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > --- > v2->3: > * Removed the definition of pinctrl-0 and pinctrl-names, as > suggested by Geert > * Added "power-domains" to the list of required properties, > as suggested by Geert > * Reworked the conditional requirements, Geert, what do you > think? Thanks for the update! > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/renesas,drif.yaml > +allOf: > + - if: > + required: > + - renesas,primary-bond > + then: > + required: > + - pinctrl-0 > + - pinctrl-names > + - port > + > + - if: > + required: > + - port > + then: > + required: > + - pinctrl-0 > + - pinctrl-names > + > + - if: > + not: > + required: > + - port > + then: This can just be an "else" branch for the previous "if" statement? > + properties: > + pinctrl-0: false > + pinctrl-names: false With the above fixed/clarified: Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds