Hi Niklas, On Wed, Oct 14, 2020 at 12:11:52PM +0200, Niklas Söderlund wrote: > Hi Jacopo, > > Thanks for your patch. > > On 2020-10-14 11:44:42 +0200, Jacopo Mondi wrote: > > Add compatible string definition for R-Car V3U. > > > > Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> > > --- > > Documentation/devicetree/bindings/media/renesas,vin.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/media/renesas,vin.yaml b/Documentation/devicetree/bindings/media/renesas,vin.yaml > > index ad2fe660364b..7b629a6ea035 100644 > > --- a/Documentation/devicetree/bindings/media/renesas,vin.yaml > > +++ b/Documentation/devicetree/bindings/media/renesas,vin.yaml > > @@ -51,6 +51,7 @@ properties: > > - renesas,vin-r8a77980 # R-Car V3H > > - renesas,vin-r8a77990 # R-Car E3 > > - renesas,vin-r8a77995 # R-Car D3 > > + - renesas,vin-r8a779a0 # R-Car V3U > > Documenting the compat string here might give the wrong impression the > IP is supported. Which it's not as the V3U is quiet different then the > it's siblings. Whit a new pipeline and small but important changes in in > the register set. I'm primarily thinking about that the IFMD register is > gone and dealing with that will be quiet significant work in the driver. > > I'm not yet 100% sure the best idea is to support V3U with this driver, > maybe it's finally time to make it more modular, with more distinct > support for Gen2, Gen3 and a new module for V3U? I see. The first concern I had that had me adding this compatible string is that otherwise I cannot specify any compatible string in the DTS device nodes... > > > > > reg: > > maxItems: 1 > > -- > > 2.28.0 > > > > -- > Regards, > Niklas Söderlund
