Re: [PATCH 1/2] arm64: dts: broadcom: remove an unused property dma-ranges

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 14, 2020 at 5:15 AM Florian Fainelli <f.fainelli@xxxxxxxxx> wrote:
> On 10/12/2020 11:06 PM, Zhen Lei wrote:
> > stingray-usb.dtsi is finally included by three dts files:
> > bcm958802a802x.dts, bcm958742k.dts and bcm958742t.dts. I searched all
> > these three entire expanded dts files, and each of them contains only one
> > dma-ranges. No conversion range is specified, so it cannot work properly.
> > I think this property "dma-ranges" is added by mistake, just remove it.
> > Otherwise, the following error will be reported when any YAML detection
> > is performed on arm64.
> >
> > arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi:7.3-14: Warning \
> > (dma_ranges_format): /usb:dma-ranges: empty "dma-ranges" property but \
> > its #address-cells (1) differs from / (2)
> > arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi:7.3-14: Warning \
> > (dma_ranges_format): /usb:dma-ranges: empty "dma-ranges" property but \
> > its #size-cells (1) differs from / (2)
> >
> > Signed-off-by: Zhen Lei <thunder.leizhen@xxxxxxxxxx>
>
> This looks fine to me, Scott, Ray do you want to Ack this patch before I
> take it?

Does it mean that there are no devices on this bus that can do DMA?

Usually there should be a dma-ranges property to identify that DMA
is possible and what the limits are, though we have failed to enforce
that.

Also note that the #address-cells=<1> means that any device under
this bus is assumed to only support 32-bit addressing, and DMA will
have to go through a slow swiotlb in the absence of an IOMMU.

      Arnd



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux