Re: [PATCH 1/2] dt-bindings: arm: fsl: add Phytec Nunki boards

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Marco,

On 07.10.20 15:34, Marco Felsch wrote:
Add missing Phytec developers to Cc.

Regards,
   Marco

On 20-10-07 15:30, Marco Felsch wrote:
Add bindings for the Phytec PhyBOARD-Nunki evalboards.

Signed-off-by: Marco Felsch <m.felsch@xxxxxxxxxxxxxx>
---
Hi,

I copied the imx6q-phytec-nunki-rdk-nand.dts and
imx6qdl-phytec-nunki.dtsi from the phytec downstream kernel repo and
added support for the imx6qp-phytec-nunki-rdk-nand.dts.

@Phytec
I adapted the "phytec,imx6q-pbac11-nand" to "phytec,imx6qp-pbac11-nand"
and "phytec,imx6q-pbac11" to "phytec,imx6qp-pbac11". Can you verify that
since I have no knowledge about the internal naming scheme, thanks.

Yes, that is correct.


Regards,
   Marco

  Documentation/devicetree/bindings/arm/fsl.yaml | 14 ++++++++++++++
  1 file changed, 14 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 6da9d734cdb7..26410a42c411 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -156,6 +156,13 @@ properties:
            - const: gw,ventana
            - const: fsl,imx6q
+ - description: i.MX6Q Phytec PhyBOARD-Nunki Board

Please use all caps for PHYTEC and start phyBOARD with a lower case p.

+        items:
+          - const: phytec,imx6q-pbac11-nand
+          - const: phytec,imx6q-pbac11
+          - const: phytec,imx6qdl-pcm058
+          - const: fsl,imx6q
+
        - description: i.MX6QP based Boards
          items:
            - enum:
@@ -163,6 +170,13 @@ properties:
                - fsl,imx6qp-sabresd        # i.MX6 Quad Plus SABRE Smart Device Board
            - const: fsl,imx6qp
+ - description: i.MX6QP Phytec PhyBOARD-Nunki Board

Same here.

With these changes you can add my
Reviewed-by: Stefan Riedmueller <s.riedmueller@xxxxxxxxx>

Thanks,
Stefan

+        items:
+          - const: phytec,imx6qp-pbac11-nand
+          - const: phytec,imx6qp-pbac11
+          - const: phytec,imx6qdl-pcm058
+          - const: fsl,imx6qp
+
        - description: i.MX6DL based Boards
          items:
            - enum:
--
2.20.1







[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux