Re: [PATCH 1/6] dt-bindings: leds: choose correct color value of multi-led

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Zhen

On 10/13/20 11:08 AM, Zhen Lei wrote:
The color value of multi-led is fixed to "const: 8 #LED_COLOR_ID_MULTI",
which is required by leds-class-multicolor.yaml.

Signed-off-by: Zhen Lei <thunder.leizhen@xxxxxxxxxx>
---
  Documentation/devicetree/bindings/leds/leds-lp55xx.yaml | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml b/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml
index 58e974793a7976b..cd877e817ad1a1c 100644
--- a/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml
@@ -197,7 +197,7 @@ examples:
                 #address-cells = <1>;
                 #size-cells = <0>;
                 reg = <0x2>;
-               color = <LED_COLOR_ID_RGB>;
+               color = <LED_COLOR_ID_MULTI>;
                 function = LED_FUNCTION_STANDBY;
                 linux,default-trigger = "heartbeat";

This is not correct.  ID_RGB is the correct variable here.

https://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git/commit/?h=for-next&id=3d93edc77515c6f51fa9bbbe2185e2ec32bad024

Correct fix is to update the leds-class-multicolor.yaml

Dan




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux