On 10/11/2020 1:32 AM, Kurt Kanzenbach wrote:
On Sat Oct 10 2020, Florian Fainelli wrote:
On 10/10/2020 9:46 AM, Kurt Kanzenbach wrote:
Convert the b53 DSA device tree bindings to YAML in order to allow
for automatic checking and such.
Suggested-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
Signed-off-by: Kurt Kanzenbach <kurt@xxxxxxxxxxxxxxxx>
Thanks for making this change, there are quite a few warnings that are
going to show up because the binding was defined in a way that it would
define chip compatible strings, which not all DTS files are using.
Oh, I didn't know there is a second make command for doing the actual
check against the dtbs. I've just used `make dt_binding_check'.
So, it seems like a lot of the errors are caused by the include files
such as
[linux]/arch/arm/boot/dts/bcm5301x.dtsi
srab: srab@18007000 {
compatible = "brcm,bcm5301x-srab";
reg = <0x18007000 0x1000>;
status = "disabled";
/* ports are defined in board DTS */
};
The nodename should be "switch" not "srab" as enforced by
dsa.yaml. Furthermore, some DTS files are not adding the chip specific
compatible strings and the ports leading to more errors.
There are also some minor errors regarding the reg-names and such for
specific instances.
How should we proceed? Adding the missing compatible strings and ports
to the DTS files? Or adjusting the include files?
The include is correct as it provides the fallback family string which
is what the driver will be looking for unless we do not provide a chip
compatible. The various DTS should be updated to contain both the chip
compatible and the fallback family (brcm,bcm5301x-srab) string, I will
update the various DTS and submit these for review later next week.
Then we could imagine me taking this YAML change through the Broadcom
ARM SoC pull requests that way no new regressions are introduced.
Sounds good?
--
Florian
