Hi!
> Thank you for the review.
Note I'm LED maintainer.
> > > + leds {
> > > + compatible = "gpio-leds";
> > > +
> > > + sdhi2_led {
> > > + label = "sdio-led";
> >
> > This should use appropriate label... probably mmc1:green:activity.
> >
> $ grep -nr mmc | grep -i activity
> $ grep -nr sd | grep -i activity
>
> Results in 0 outputs in dts folder.
Well, so does
grep -ri label.*sdio-led arch/arm*
:-). Feel free to suggest other name following documentation in
Documentation/leds/leds-class.rst .
(And yes, we have lot of work to get this to some kind of consistent
state).
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Attachment:
signature.asc
Description: PGP signature
