On Tue, Jun 17, 2014 at 05:11:05PM +0100, Mark Rutland wrote: > On Tue, Jun 17, 2014 at 09:11:53AM +0100, Heiko Schocher wrote: > > Driver for the TI TMP103. > > > > The TI TMP103 is similar to the TMP102. It differs from the TMP102 > > by having only 8 bit registers. > > > > Signed-off-by: Heiko Schocher <hs@xxxxxxx> > > [ ... ] > > + > > +static const struct i2c_device_id tmp103_id[] = { > > + { DRIVER_NAME, 0 }, > > This seems to be used for compatible string matching. As such, I think > it would make more sense to have the string in full here so as to > discourage it from being changed arbitrarily in future. > Makes sense. Heiko, can you change that as well in v5 ? It also simplifies adding another chip to the driver, should that ever happen. Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html