On Fri, Oct 9, 2020 at 12:28 AM Ricardo Cañuelo <ricardo.canuelo@xxxxxxxxxxxxx> wrote: > > Hi Rob, > > Thanks for reviewing the patch > > On jue 08-10-2020 13:32:41, Rob Herring wrote: > > These already have a type and description, don't repeat it here. > > > > If no other constraints, then just 'linux,keymap: true'. Or you can use > > unevaluatedProperties instead of additionalProperties. The former will > > take the $ref to matrix-keymap.yaml into account. > > That's what I did in v1, using input/imx-keypad.yaml as an example along > with the comment in example-schema.yaml about unevaluatedProperties, but > then I also saw you mention in other threads that support for > unevaluatedProperties is not implemented yet and that documenting the > additional properties/nodes is preferred (that's what I understood, at > least): > > https://lore.kernel.org/dri-devel/CAL_JsqKPXJxsHPS34_TCf9bwgKxZNSV4mvQR-WKRnknQVtGGxQ@xxxxxxxxxxxxxx/ > > Was it right in v1 then? Yes. There is some value in explicitly listing the properties here if only a subset of them are valid for this binding, but that's not the case here. Rob
