Re: [PATCH 1/2] regulator: max1586 add device-tree support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Sat, Jun 14, 2014 at 04:54:24PM +0200, Robert Jarzmik wrote:

> +	matched = of_regulator_match(dev, np, rmatch, ARRAY_SIZE(rmatch));
> +	of_node_put(np);
> +	if (matched <= 0)
> +		return matched;

Why is this treating zero as an error?  We should be able to at least
report the current state of regulators even if none are configured in
the device tree.

Otherwise this looks good.

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux