Hi Geert, On Fri, Sep 25, 2020 at 2:48 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > Hi Mateusz, > > On Wed, Sep 23, 2020 at 12:09 PM Mateusz Holenko <mholenko@xxxxxxxxxxxx> wrote: > > From: Pawel Czarnecki <pczarnecki@xxxxxxxxxxxxxxxxxxxxxxxx> > > > > Add documentation for LiteX SoC Controller bindings. > > > > Signed-off-by: Pawel Czarnecki <pczarnecki@xxxxxxxxxxxxxxxxxxxxxxxx> > > Signed-off-by: Mateusz Holenko <mholenko@xxxxxxxxxxxx> > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > > Thanks for your patch! Thanks for your comments! > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml > > @@ -0,0 +1,39 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +# Copyright 2020 Antmicro <www.antmicro.com> > > +%YAML 1.2 > > +--- > > +$id: "http://devicetree.org/schemas/soc/litex/litex,soc-controller.yaml#"; > > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"; > > + > > +title: LiteX SoC Controller driver > > + > > +description: | > > + This is the SoC Controller driver for the LiteX SoC Builder. > > + It's purpose is to verify LiteX CSR (Control&Status Register) access > > Its > > > + operations and provide function for other drivers to read/write CSRs > > functions > > > + and to check if those accessors are ready to use. > > be used I will fix the description as suggested. > > + > > +maintainers: > > + - Karol Gugala <kgugala@xxxxxxxxxxxx> > > + - Mateusz Holenko <mholenko@xxxxxxxxxxxx> > > + > > +properties: > > + compatible: > > + const: litex,soc-controller > > + > > + reg: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + > > +examples: > > + - | > > + soc_ctrl0: soc-controller@f0000000 { > > + compatible = "litex,soc-controller"; > > + reg = <0xf0000000 0xC>; > > Please be consistent w.r.t. lower/upper case: "0xc". Sure, I will use lowercase everywhere. > > + status = "okay"; > > + }; > > Gr{oetje,eeting}s, > > Geert > > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds Best regards, Mateusz -- Mateusz Holenko Antmicro Ltd | www.antmicro.com Roosevelta 22, 60-829 Poznan, Poland
