RE: [PATCH v4 1/4] dt-bindings: usb: dwc3-imx8mp: add imx8mp dwc3 glue bindings

[Jun Li <jun.li@xxxxxxx>]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Sent: Saturday, October 3, 2020 6:57 PM
> To: Jun Li <jun.li@xxxxxxx>
> Cc: robh+dt@xxxxxxxxxx; shawnguo@xxxxxxxxxx; balbi@xxxxxxxxxx;
> mathias.nyman@xxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx;
> s.hauer@xxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx;
> dl-linux-imx <linux-imx@xxxxxxx>; Anson Huang <anson.huang@xxxxxxx>;
> Aisheng Dong <aisheng.dong@xxxxxxx>; Peng Fan <peng.fan@xxxxxxx>; Andy Duan
> <fugang.duan@xxxxxxx>; Horia Geanta <horia.geanta@xxxxxxx>;
> linux-usb@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v4 1/4] dt-bindings: usb: dwc3-imx8mp: add imx8mp dwc3
> glue bindings
> 
> On Fri, 2 Oct 2020 at 18:35, Li Jun <jun.li@xxxxxxx> wrote:
> >
> > NXP imx8mp integrates 2 dwc3 3.30b IP and add some wakeup logic to
> > support low power mode, the glue layer is for this wakeup
> > functionality, which has a separated interrupt, can support wakeup
> > from U3 and connect events for host, and vbus wakeup for device.
> >
> > Signed-off-by: Li Jun <jun.li@xxxxxxx>
> > ---
> >  .../devicetree/bindings/usb/fsl,imx8mp-dwc3.yaml   | 106
> +++++++++++++++++++++
> >  1 file changed, 106 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/usb/fsl,imx8mp-dwc3.yaml
> > b/Documentation/devicetree/bindings/usb/fsl,imx8mp-dwc3.yaml
> > new file mode 100644
> > index 0000000..c16c94c
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/usb/fsl,imx8mp-dwc3.yaml
> > @@ -0,0 +1,106 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) # Copyright
> > +(c) 2020 NXP %YAML 1.2
> > +---
> > +$id:
> >
> +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi
> >
> +cetree.org%2Fschemas%2Fusb%2Ffsl%2Cimx8mp-dwc3.yaml%23&amp;data=02%7C
> >
> +01%7Cjun.li%40nxp.com%7C65dadb86aff34a97750d08d8678b1b8d%7C686ea1d3bc
> >
> +2b4c6fa92cd99c5c301635%7C0%7C0%7C637373194445369560&amp;sdata=yL%2BCJ
> > +XVhWnS2LlnwlF3793dygxPDFJVCZhVQcj8DJDI%3D&amp;reserved=0
> > +$schema:
> >
> +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi
> >
> +cetree.org%2Fmeta-schemas%2Fcore.yaml%23&amp;data=02%7C01%7Cjun.li%40
> >
> +nxp.com%7C65dadb86aff34a97750d08d8678b1b8d%7C686ea1d3bc2b4c6fa92cd99c
> >
> +5c301635%7C0%7C0%7C637373194445369560&amp;sdata=K2%2FUvKrKEeFf5J4M5dC
> > +L5f%2B7nVBSDPxUopZgwlfeN8I%3D&amp;reserved=0
> > +
> > +title: NXP iMX8MP Soc USB Controller
> > +
> > +maintainers:
> > +  - Li Jun <jun.li@xxxxxxx>
> > +
> > +properties:
> > +  compatible:
> > +    items:
> > +    - const: fsl,imx8mp-dwc3
> 
> The same comment as for v3.

Missed this comment, sent out V5 to address this.

Thanks
Li Jun
> 
> Best regards,
> Krzysztof