On Thu, Sep 17, 2020 at 08:52:10PM +0200, Krzysztof Kozlowski wrote: > GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. > These are simple defines so they could be used in DTS but they will not > have the same meaning: > 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE > 2. GPIO_ACTIVE_LOW = 1 = IRQ_TYPE_EDGE_RISING > > Correct the interrupt flags without affecting the code: > ACTIVE_HIGH => IRQ_TYPE_NONE > > Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > > --- > > Not tested on HW. > > Changes since v1: > 1. Correct title > --- > arch/arm/boot/dts/rk3188-bqedison2qc.dts | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Hi, Any comments/review/testing from Heiko or other Rockchip folks? Shall I cc here someone? Best regards, Krzysztof