On Fri, Oct 02, 2020 at 03:39:52PM +0200, Greg Kroah-Hartman wrote: > On Mon, Sep 28, 2020 at 07:39:51PM -0700, Badhri Jagan Sridharan wrote: > > set_vbus callback allows TCPC which are TCPCI based, however, > > does not support turning on sink and source mode through > > Command.SinkVbus and Command.SourceVbusDefaultVoltage. > > > > Signed-off-by: Badhri Jagan Sridharan <badhri@xxxxxxxxxx> > > Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> > > This patch breaks the build, are you sure you tested it? Sorry, not this patch, patch 4: drivers/usb/typec/tcpm/tcpci.c: In function ‘tcpci_register_port’: drivers/usb/typec/tcpm/tcpci.c:630:13: error: ‘struct tcpc_dev’ has no member named ‘enable_frs’ 630 | tcpci->tcpc.enable_frs = tcpci_enable_frs; | ^ thanks, greg k-h