Mark Brown <broonie@xxxxxxxxxx> 於 2020年9月30日 週三 下午5:43寫道: > > On Wed, Sep 30, 2020 at 10:23:49AM +0800, ChiYuan Huang wrote: > > > Due to that already merged into your regulator for-next git, may I > > send the patch to fix Rob's comment? > > Of course, yes please. OK, Thx. > > > And I also found one line need to be added into rtmv20 probe phase. > > Please check below. > > /* > > * keep in shutdown mode to minimize the current consumption > > * and also mark regcache as dirty > > */ > > + regcache_cache_only(priv->regmap, true); > > regcache_mark_dirty(priv->regmap); > > gpiod_set_value(priv->enable_gpio, 0); > > > > Can I directly merge into one that includes Rob's comment and the > > above line to be added? > > Please make it a separate patch. I'll send the separate patch by next.