Tushar, On Mon, Jun 16, 2014 at 4:19 AM, Tushar Behera <trblinux@xxxxxxxxx> wrote: > On 06/13/2014 10:33 PM, Doug Anderson wrote: >> Tushar, >> >> On Tue, Jun 10, 2014 at 10:32 PM, Tushar Behera <tushar.b@xxxxxxxxxxx> wrote: >>> Peach-pi board has MAX98090 audio codec connected on HSI2C-7 bus. >> >> If you want to be a stickler about it, peach-pi actually has a >> max98091. That requires code changes to the i2c driver, though. >> ...and unfortunately listing two compatible strings for i2c devices is >> broken. :( >> > Hi Doug, > > You are right. I checked the boot logs, the detected codec type is > MAX98091. Since both these CODECs are supported through a single driver > and the detection of chip is done during runtime, I would suggest we go > ahead with "max98090" compatible string. I will update the commit > message accordingly. > > Does that sound okay to you? As per my understanding you shouldn't do this. You should have two patches: 1. Add "max98091". You could simply post Wonjoon's patch from <https://chromium-review.googlesource.com/184091> 2. Change the device tree to refer to "max98091" The argument that the "current kernel driver has a single driver" is an argument that you're not supposed to make for device tree. The same device tree is supposed to work for U-Boot, BSD, or any other platform. On those platforms it might not be a shared driver. > If you so desire, I will submit a patch to sort peach-pi device-tree > nodes (w.r.t. peach-pit dts file). Yes please. I think there's supposed to be some official ordering of things. If anyone reading this has a pointer to the official sort order of things in the device tree I'd love to see it! ;) -Doug -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
