Hi Lee, On Tue, Sep 29, 2020 at 10:48:57AM +0100, Lee Jones wrote: > On Sat, 22 Aug 2020, kernel test robot wrote: > > > Hi Cristian, > > > > Thank you for the patch! Yet something to improve: > > > > [auto build test ERROR on lee-mfd/for-mfd-next] > > [also build test ERROR on regulator/for-next v5.9-rc1 next-20200821] > > [cannot apply to input/next power-supply/for-next] > > [If your patch is applied to the wrong git tree, kindly drop us a note. > > And when submitting patch, we suggest to use '--base' as documented in > > https://git-scm.com/docs/git-format-patch] > > > > url: https://github.com/0day-ci/linux/commits/Cristian-Ciocaltea/Add-initial-support-for-ATC260x-PMICs/20200822-062126 > > base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next > > config: sh-allmodconfig (attached as .config) > > compiler: sh4-linux-gcc (GCC) 9.3.0 > > reproduce (this is a W=1 build): > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > # save the attached .config to linux build tree > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh > > > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > > > > All errors (new ones prefixed by >>, old ones prefixed by <<): > > > > WARNING: modpost: missing MODULE_LICENSE() in drivers/mfd/atc260x-core.o > > >> FATAL: modpost: drivers/mfd/atc260x-i2c: sizeof(struct i2c_device_id)=24 is not a modulo of the size of section __mod_i2c__<identifier>_device_table=588. > > >> Fix definition of struct i2c_device_id in mod_devicetable.h > > > > --- > > 0-DAY CI Kernel Test Service, Intel Corporation > > https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx > > Is this something you plan to fix? Yes, I was just waiting to get some initial feedback for the drivers code before submitting a new revision. Except for the MFD core, I think this is almost completed. > -- > Lee Jones [李琼斯] > Senior Technical Lead - Developer Services > Linaro.org │ Open source software for Arm SoCs > Follow Linaro: Facebook | Twitter | Blog Kind regards, Cristi