Hi Laurent, On Mon, Jun 16, 2014 at 4:22 PM, Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote: >> diff --git a/arch/arm/boot/dts/r8a7779.dtsi b/arch/arm/boot/dts/r8a7779.dtsi >> index bf716ce..81714ce 100644 >> --- a/arch/arm/boot/dts/r8a7779.dtsi >> +++ b/arch/arm/boot/dts/r8a7779.dtsi >> @@ -269,9 +269,10 @@ >> tmu0: timer@ffd80000 { >> compatible = "renesas,tmu"; >> reg = <0xffd80000 0x30>; >> - interrupts = <0 40 IRQ_TYPE_LEVEL_HIGH>, >> - <0 41 IRQ_TYPE_LEVEL_HIGH>, >> - <0 42 IRQ_TYPE_LEVEL_HIGH>; >> + interrupt-parent = <&gic>; >> + interrupts = <0 32 IRQ_TYPE_LEVEL_HIGH>, >> + <0 33 IRQ_TYPE_LEVEL_HIGH>, >> + <0 34 IRQ_TYPE_LEVEL_HIGH>; >> clocks = <&mstp0_clks R8A7779_CLK_TMU0>; >> clock-names = "fck"; >> >> @@ -283,9 +284,10 @@ >> tmu1: timer@ffd81000 { >> compatible = "renesas,tmu"; >> reg = <0xffd81000 0x30>; >> - interrupts = <0 44 IRQ_TYPE_LEVEL_HIGH>, >> - <0 45 IRQ_TYPE_LEVEL_HIGH>, >> - <0 46 IRQ_TYPE_LEVEL_HIGH>; >> + interrupt-parent = <&gic>; >> + interrupts = <0 35 IRQ_TYPE_LEVEL_HIGH>, >> + <0 36 IRQ_TYPE_LEVEL_HIGH>, >> + <0 37 IRQ_TYPE_LEVEL_HIGH>; > > If I'm not mistaken the interrupts should be 36, 37 and 38. (diving into the documentation) Yes, probably 36, 37, and 38. I say "probably", as I find it non-trivial to convert from docs to DT. What happens with 35, which is "TMU21 (input capture)"? As DT describes the hardware, shouldn't it be mentioned here? >> clocks = <&mstp0_clks R8A7779_CLK_TMU1>; >> clock-names = "fck"; >> >> @@ -296,10 +298,11 @@ >> >> tmu2: timer@ffd82000 { >> compatible = "renesas,tmu"; >> + interrupt-parent = <&gic>; >> reg = <0xffd82000 0x30>; >> - interrupts = <0 48 IRQ_TYPE_LEVEL_HIGH>, >> - <0 49 IRQ_TYPE_LEVEL_HIGH>, >> - <0 50 IRQ_TYPE_LEVEL_HIGH>; >> + interrupts = <0 38 IRQ_TYPE_LEVEL_HIGH>, >> + <0 39 IRQ_TYPE_LEVEL_HIGH>, >> + <0 40 IRQ_TYPE_LEVEL_HIGH>; > > And 40, 41 and 42 here. Likewise for "TMU51 (input capture)"? >> clocks = <&mstp0_clks R8A7779_CLK_TMU2>; >> clock-names = "fck"; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html