On Wed, Sep 23, 2020 at 3:17 PM Andreas Kemnade <andreas@xxxxxxxxxxxx> wrote: > > On Tue, 22 Sep 2020 19:40:41 -0600 > Rob Herring <robh@xxxxxxxxxx> wrote: > > > On Wed, Sep 16, 2020 at 08:17:57AM +0200, Andreas Kemnade wrote: > > > Convert the RN5T618 binding to DT schema format. Also > > > clearly state which regulators are available. > > > > > > Signed-off-by: Andreas Kemnade <andreas@xxxxxxxxxxxx> > > > --- > > > Changes in v2: > > > - drop irq description > > > > > > Due to its .txt-format history BSD license was not added. > > > .../bindings/mfd/ricoh,rn5t618.yaml | 111 ++++++++++++++++++ > > > .../devicetree/bindings/mfd/rn5t618.txt | 52 -------- > > > 2 files changed, 111 insertions(+), 52 deletions(-) > > > create mode 100644 Documentation/devicetree/bindings/mfd/ricoh,rn5t618.yaml > > > delete mode 100644 Documentation/devicetree/bindings/mfd/rn5t618.txt > > > > > > diff --git a/Documentation/devicetree/bindings/mfd/ricoh,rn5t618.yaml b/Documentation/devicetree/bindings/mfd/ricoh,rn5t618.yaml > > > new file mode 100644 > > > index 000000000000..d70e85a09c84 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/mfd/ricoh,rn5t618.yaml > > > @@ -0,0 +1,111 @@ > > > +# SPDX-License-Identifier: GPL-2.0 > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/mfd/ricoh,rn5t618.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Ricoh RN5T567/RN5T618/RC5T619 PMIC > > > + > > > +maintainers: > > > + - Andreas Kemnade <andreas@xxxxxxxxxxxx> > > > + > > > +description: | > > > + Ricoh RN5T567/RN5T618/RC5T619 is a power management IC family which > > > + integrates 3 to 5 step-down DCDC converters, 7 to 10 low-dropout regulators, > > > + GPIOs, and a watchdog timer. It can be controlled through an I2C interface. > > > + The RN5T618/RC5T619 provides additionally a Li-ion battery charger, > > > + fuel gauge, and an ADC. > > > + The RC5T619 additionnally includes USB charger detection and an RTC. > > > + > > > +allOf: > > > + - if: > > > + properties: > > > + compatible: > > > + contains: > > > + const: ricoh,rn5t567 > > > + then: > > > + properties: > > > + regulators: > > > + patternProperties: > > > + "^(DCDC[1-4]|LDO[1-5]|LDORTC[12])$": > > > + $ref: ../regulator/regulator.yaml > > > + additionalProperties: false > > > + - if: > > > + properties: > > > + compatible: > > > + contains: > > > + const: ricoh,rn5t618 > > > + then: > > > + properties: > > > + regulators: > > > + patternProperties: > > > + "^(DCDC[1-3]|LDO[1-5]|LDORTC[12])$": > > > + $ref: ../regulator/regulator.yaml > > > + additionalProperties: false > > > + - if: > > > + properties: > > > + compatible: > > > + contains: > > > + const: ricoh,rc5t619 > > > + then: > > > + properties: > > > + regulators: > > > + patternProperties: > > > + "^(DCDC[1-5]|LDO[1-9]|LDO10|LDORTC[12])$": > > > + $ref: ../regulator/regulator.yaml > > > + additionalProperties: false > > > + > > > +properties: > > > + compatible: > > > + enum: > > > + - ricoh,rn5t567 > > > + - ricoh,rn5t618 > > > + - ricoh,rc5t619 > > > + > > > + reg: > > > + maxItems: 1 > > > + > > > + interrupts: > > > + maxItems: 1 > > > + > > > + system-power-controller: > > > + type: boolean > > > + description: | > > > + See Documentation/devicetree/bindings/power/power-controller.txt > > > + > > > + regulators: > > > + type: object > > > > Add here: > > > > $ref: ../regulator/regulator.yaml > > > > And then the occurrances up above can be just 'true'. > > > That feels wrong. I would think that gets applied to things directly > below regulator node and not to the individual regulator subnodes. To > check that I did: Ah right, you'd need another level in there. I guess just leave it as is. Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
