> -----Original Message----- > From: Krzysztof Kozlowski [mailto:krzk@xxxxxxxxxx] > Sent: Tuesday, September 29, 2020 4:02 PM > To: Jacky Bai <ping.bai@xxxxxxx> > Cc: shawnguo@xxxxxxxxxx; robh+dt@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; > festevam@xxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>; > devicetree@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 2/2] arm64: dts: freescale: Add pmu support on imx8mn > > On Sun, Sep 27, 2020 at 05:47:42PM +0800, Jacky Bai wrote: > > Add PMU node to enable pmu support on imx8mn. > > > > Signed-off-by: Jacky Bai <ping.bai@xxxxxxx> > > --- > > arch/arm64/boot/dts/freescale/imx8mn.dtsi | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi > > b/arch/arm64/boot/dts/freescale/imx8mn.dtsi > > index 746faf1cf2fb..589835d78727 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi > > @@ -186,6 +186,14 @@ clk_ext4: clock-ext4 { > > clock-output-names = "clk_ext4"; > > }; > > > > + pmu { > > + compatible = "arm,armv8-pmuv3"; > > + interrupts = <GIC_PPI 7 > > + (GIC_CPU_MASK_SIMPLE(6) | IRQ_TYPE_LEVEL_HIGH)>; > > The same as in 1/2 - unusual value for GIC_CPU_MASK_SIMPLE. There are > four cores on Nano. > Thanks for review, will fix in v2. BR > Best regards, > Krzysztof
