Hi,
On Mon, Sep 28, 2020 at 10:14 AM Matthias Kaehlcke <mka@xxxxxxxxxxxx> wrote:
>
> +examples:
> + - |
> + usb_hub: usb-hub {
> + compatible = "realtek,rts5411", "onboard-usb-hub";
> + vdd-supply = <&pp3300_hub>;
> + };
> +
> + usb_controller {
Super nitty nit: prefer dashes for node names.
> + dr_mode = "host";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + /* 2.0 hub on port 1 */
> + hub@1 {
> + compatible = "usbbda,5411";
Presumably we need something in the bindings for "usbbda,5411" ?
> + reg = <1>;
> + hub = <&usb_hub>;
> + };
> +
> + /* 3.0 hub on port 2 */
> + hub@2 {
> + compatible = "usbbda,411";
Presumably we need something in the bindings for "usbbda,411" ?
-Doug
