Re: [PATCH RFC 1/8] dt-bindings: thermal: Introduce monitor-falling parameter to thermal trip point binding

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Rob,
Thanks for the review.

On 9/23/20 12:03 PM, Rob Herring wrote:
On Wed, Sep 16, 2020 at 11:22:19PM -0400, Thara Gopinath wrote:
Introduce a new binding parameter to thermal trip point description
to indicate whether the temperature level specified by the trip point
is monitored for a rise or fall in temperature.

Signed-off-by: Thara Gopinath <thara.gopinath@xxxxxxxxxx>
---
  .../devicetree/bindings/thermal/thermal-zones.yaml         | 7 +++++++
  1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/thermal/thermal-zones.yaml b/Documentation/devicetree/bindings/thermal/thermal-zones.yaml
index 3ec9cc87ec50..cc1332ad6c16 100644
--- a/Documentation/devicetree/bindings/thermal/thermal-zones.yaml
+++ b/Documentation/devicetree/bindings/thermal/thermal-zones.yaml
@@ -161,6 +161,13 @@ patternProperties:
                    The active trip type can be used to control other HW to
                    help in cooling e.g. fans can be sped up or slowed down
+ monitor-falling:
+                description: |
+                  boolean, If true, the trip point is being monitored for
+                  falling temperature. If false/absent/default, the trip
+                  point is being monitored for rising temperature.
+                type: boolean

What if you wanted to monitor for both?

You usually don't want to. At really low temperature trip (5 degree C or 0 degree C) you care about starting to monitor when the temperature falls below the trip. At high temp trip points, you care about starting to monitor when the temperature rises above the trip point. The thermal framework takes care of stopping the monitoring (dependent on type of monitoring, hysteresis etc.)

+
              required:
                - temperature
                - hysteresis
--
2.25.1


--
Warm Regards
Thara



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux