On 2020/9/28 17:50, Jonathan Cameron wrote: > On Sun, 27 Sep 2020 14:21:28 +0800 > Zhen Lei <thunder.leizhen@xxxxxxxxxx> wrote: > >> Convert the Hisilicon Hi6220 SRAM controller binding to DT schema format >> using json-schema. >> >> Signed-off-by: Zhen Lei <thunder.leizhen@xxxxxxxxxx> >> --- >> .../hi3620/hisilicon,hi6220-sramctrl.txt | 16 --------- >> .../hi3620/hisilicon,hi6220-sramctrl.yaml | 38 ++++++++++++++++++++++ >> 2 files changed, 38 insertions(+), 16 deletions(-) >> delete mode 100644 Documentation/devicetree/bindings/arm/hisilicon/controller/hi3620/hisilicon,hi6220-sramctrl.txt >> create mode 100644 Documentation/devicetree/bindings/arm/hisilicon/controller/hi3620/hisilicon,hi6220-sramctrl.yaml >> >> diff --git a/Documentation/devicetree/bindings/arm/hisilicon/controller/hi3620/hisilicon,hi6220-sramctrl.txt b/Documentation/devicetree/bindings/arm/hisilicon/controller/hi3620/hisilicon,hi6220-sramctrl.txt >> deleted file mode 100644 >> index 963a2cb13a249d9..000000000000000 >> --- a/Documentation/devicetree/bindings/arm/hisilicon/controller/hi3620/hisilicon,hi6220-sramctrl.txt >> +++ /dev/null >> @@ -1,16 +0,0 @@ >> -Hisilicon Hi6220 SRAM controller >> - >> -Required properties: >> -- compatible : "hisilicon,hi6220-sramctrl", "syscon" >> -- reg : Register address and size >> - >> -Hisilicon's SoCs use sram for multiple purpose; on Hi6220 there have several >> -SRAM banks for power management, modem, security, etc. Further, use "syscon" >> -managing the common sram which can be shared by multiple modules. >> - >> -Example: >> - /*for Hi6220*/ >> - sram: sram@fff80000 { >> - compatible = "hisilicon,hi6220-sramctrl", "syscon"; >> - reg = <0x0 0xfff80000 0x0 0x12000>; >> - }; >> \ No newline at end of file >> diff --git a/Documentation/devicetree/bindings/arm/hisilicon/controller/hi3620/hisilicon,hi6220-sramctrl.yaml b/Documentation/devicetree/bindings/arm/hisilicon/controller/hi3620/hisilicon,hi6220-sramctrl.yaml >> new file mode 100644 >> index 000000000000000..f66d414a7a48071 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/arm/hisilicon/controller/hi3620/hisilicon,hi6220-sramctrl.yaml >> @@ -0,0 +1,38 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/arm/hisilicon/controller/hi3620/hisilicon,hi6220-sramctrl.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Hisilicon Hi6220 SRAM controller >> + >> +maintainers: >> + - Wei Xu <xuwei5@xxxxxxxxxxxxx> >> + >> +description: | >> + Hisilicon's SoCs use sram for multiple purpose; on Hi6220 there have several > > SRAM for consistency OK, I will correct it. > >> + SRAM banks for power management, modem, security, etc. Further, use "syscon" >> + managing the common sram which can be shared by multiple modules. >> + >> +properties: >> + compatible: >> + items: >> + - const: hisilicon,hi6220-sramctrl >> + - const: syscon >> + >> + reg: >> + description: Register address and size >> + maxItems: 1 >> + >> +required: >> + - compatible >> + - reg >> + >> +examples: >> + - | >> + /* for Hi6220 */ >> + sram: sram@fff80000 { >> + compatible = "hisilicon,hi6220-sramctrl", "syscon"; >> + reg = <0xfff80000 0x12000>; >> + }; >> +... >> \ No newline at end of file > > As per other files that have this, please add one. > > > > > . >