On Wed, 23 Sep 2020 at 16:48, Tomer Maimon <tmaimon77@xxxxxxxxx> wrote: > > Add pin controller and GPIO node to NPCM7XX device tree. > > Signed-off-by: Tomer Maimon <tmaimon77@xxxxxxxxx> > --- > arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi | 565 ++++++++++++++++++ > 1 file changed, 565 insertions(+) > > diff --git a/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi b/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi > index 72e364054e72..5df77a617e77 100644 > --- a/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi > +++ b/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi > @@ -185,4 +185,569 @@ > }; > }; > }; > + > + pinctrl: pinctrl@f0800000 { > + #address-cells = <1>; > + #size-cells = <1>; > + compatible = "nuvoton,npcm750-pinctrl", "syscon", "simple-mfd"; > + ranges = <0 0xf0010000 0x8000>; > + status = "okay"; Nodes are enabled by default, so there's no need to add status="okay" here. It's no biggie, you can fix it up in a follow up patch. Reviewed-by: Joel Stanley <joel@xxxxxxxxx>