Hi Leo, Rob, On Tuesday, September 22, 2020 6:20 AM, Leo Li wrote: > > > -----Original Message----- > > From: Ran Wang <ran.wang_1@xxxxxxx> > > Sent: Wednesday, September 16, 2020 3:18 AM > > To: Leo Li <leoyang.li@xxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; > > Shawn Guo <shawnguo@xxxxxxxxxx> > > Cc: linuxppc-dev@xxxxxxxxxxxxxxxx; > > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; > > devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Biwen Li > > <biwen.li@xxxxxxx>; Ran Wang <ran.wang_1@xxxxxxx> > > Subject: [PATCH 1/5] Documentation: dt: binding: fsl: Add > > 'fsl,ippdexpcr1-alt- addr' property > > > > From: Biwen Li <biwen.li@xxxxxxx> > > > > The 'fsl,ippdexpcr1-alt-addr' property is used to handle an errata > > A-008646 on LS1021A > > It looks like the previous version of this patch has gotten the reviewed-by from > Rob. It would be good to be added to the patch for new submission. Actually this patch has one update from previous version (https://lore.kernel.org/patchwork/patch/1161631/): Reduce entry number from 3 to 2. So I'd like to have a review for this one, sorry for not highlight this in advance. Regards, Ran > > > > Signed-off-by: Biwen Li <biwen.li@xxxxxxx> > > Signed-off-by: Ran Wang <ran.wang_1@xxxxxxx> > > --- > > Documentation/devicetree/bindings/soc/fsl/rcpm.txt | 19 > > +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/soc/fsl/rcpm.txt > > b/Documentation/devicetree/bindings/soc/fsl/rcpm.txt > > index 5a33619..1be58a3 100644 > > --- a/Documentation/devicetree/bindings/soc/fsl/rcpm.txt > > +++ b/Documentation/devicetree/bindings/soc/fsl/rcpm.txt > > @@ -34,6 +34,11 @@ Chassis Version Example Chips > > Optional properties: > > - little-endian : RCPM register block is Little Endian. Without it RCPM > > will be Big Endian (default case). > > + - fsl,ippdexpcr1-alt-addr : The property is related to a hardware issue > > + on SoC LS1021A and only needed on SoC LS1021A. > > + Must include 2 entries: > > + The first entry must be a link to the SCFG device node. > > + The 2nd entry must be offset of register IPPDEXPCR1 in SCFG. > > > > Example: > > The RCPM node for T4240: > > @@ -43,6 +48,20 @@ The RCPM node for T4240: > > #fsl,rcpm-wakeup-cells = <2>; > > }; > > > > +The RCPM node for LS1021A: > > + rcpm: rcpm@1ee2140 { > > + compatible = "fsl,ls1021a-rcpm", "fsl,qoriq-rcpm-2.1+"; > > + reg = <0x0 0x1ee2140 0x0 0x8>; > > + #fsl,rcpm-wakeup-cells = <2>; > > + > > + /* > > + * The second and third entry compose an alt offset > > + * address for IPPDEXPCR1(SCFG_SPARECR8) > > + */ > > + fsl,ippdexpcr1-alt-addr = <&scfg 0x51c>; > > + }; > > + > > + > > * Freescale RCPM Wakeup Source Device Tree Bindings > > ------------------------------------------- > > Required fsl,rcpm-wakeup property should be added to a device node if > > the device > > -- > > 2.7.4
