On Thu, Jun 12, 2014 at 10:31:19PM +0530, Jassi Brar wrote:
A couple of tiny nits, I'll send followup patches for these.
> +bool mbox_client_peek_data(struct mbox_chan *chan)
> +{
> + if (chan->mbox->ops->peek_data)
> + return chan->mbox->ops->peek_data(chan);
> +
> + return false;
> +}
> +EXPORT_SYMBOL_GPL(mbox_client_peek_data);
This isn't declared in the header to allow users to use it.
> +struct mbox_chan *mbox_request_channel(const struct mbox_client *cl)
> + spin_lock_irqsave(&chan->lock, flags);
> + chan->msg_free = 0;
> + chan->msg_count = 0;
> + chan->active_req = NULL;
> + chan->cl = cl;
chan->cl is non-const but cl is const so this assignment is invalid.
Attachment:
signature.asc
Description: Digital signature
