On 18/09/2020 04:18, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Wed, Sep 16, 2020 at 04:10:08PM +0300, Tomi Valkeinen wrote: >> Add assigned-clocks, assigned-clock-parents and dma-coherent optional >> properties. >> >> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx> >> Reviewed-by: Rob Herring <robh@xxxxxxxxxx> >> --- >> .../devicetree/bindings/display/ti/ti,am65x-dss.yaml | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml >> index 4f9185462ed3..4dc30738ee57 100644 >> --- a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml >> +++ b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml >> @@ -55,6 +55,14 @@ properties: >> - const: vp1 >> - const: vp2 >> >> + assigned-clocks: >> + minItems: 1 >> + maxItems: 3 >> + >> + assigned-clock-parents: >> + minItems: 1 >> + maxItems: 3 >> + > > Those properties can occur in any node that has clocks. Do we need to > specify them explicitly in every schema ? I don't really know the dt-schema stuff well enough yet to have a good answer, but if this information would come from somewhere else, it would somehow need to know: - are there clocks in this schema (i.e. is assigned-clocks allowed or not) - how many clocks there are (for min and max items) This would also apply to assigned-clock-rates. Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
