Hi! On 2020-09-16 17:45, Nishanth Menon wrote: > On 06:52-20200916, Peter Rosin wrote: >> Hi, >> >> Sorry for the delay. >> >> On 2020-09-15 13:20, Roger Quadros wrote: >>> Each SERDES lane mux can select upto 4 different IPs. >>> There are 4 lanes in each J7200 SERDES. Define all >>> the possible functions in this file. >>> >>> Cc: Peter Rosin <peda@xxxxxxxxxx> >>> Signed-off-by: Roger Quadros <rogerq@xxxxxx> >>> --- *snip* >> Should not the defines start with J7200_WIZ? SERDES0 seems like a too >> generic prefix, at least to me. > > Thanks, good point. I am not sure if WIZ should even be used.. It is > a TI internal prefix for various serdes solutions, but I agree that > SERDES0 is too generic a terminology. That said, we should cleanup > include/dt-bindings/mux/mux-j721e-wiz.h as well, prior to introducing > j7200 changes. Right. As maintainer for the directory in question, I should have been on Cc for that series too, but it appears I wasn't. Hence, I didn't notice that file until now when I went looking for it. Why wasn't I on Cc? Cheers, Peter
