On Sun, 13 Sep 2020 at 04:32, Shawn Guo <shawnguo@xxxxxxxxxx> wrote: > > Add Tim who is the board owner. > > On Tue, Sep 08, 2020 at 05:02:34PM +0200, Krzysztof Kozlowski wrote: > > GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. > > These are simple defines so they could be used in DTS but they will not > > have the same meaning: > > 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE > > 2. GPIO_ACTIVE_LOW = 1 = IRQ_TYPE_EDGE_RISING > > > > Correct the interrupt flags, assuming the author of the code wanted some > > logical behavior behind the name "ACTIVE_xxx", this is: > > ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW > > > > Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > > The subject prefix could be a bit more specific, like 'ARM: dts: > imx6qdl-gw5xxx'. Also, I do not quite understand meaning of 'in > examples' in subject. That's my copy-paste error. I'll resend with a proper subject. Best regards, Krzysztof
