Hi, On Tue, Sep 15, 2020 at 07:58:38PM +0200, Kurt Van Dijck wrote: > On di, 15 sep 2020 21:49:25 +0530, Manivannan Sadhasivam wrote: > > Hi, > > > > On Thu, Sep 10, 2020 at 07:08:00PM +0530, Manivannan Sadhasivam wrote: > > > Hello, > > > > Just a quick question: I don't see any activity on this specific driver for > > sometime (back in Martin days itself). Is it due to lack of reviewers or > > it is due to the patch size (lines of code) so that nobody is interested > > in reviewing? > > If you look around, there are currently several versions of mcp251x > driver around, shipped by hardware vendors who glue the chip on there > SOM etc. > Until something more-or-less clean becomes mainline, the effort remains > spread. > > A problem to import a complete driver is that ... its complete. > There was an suggestion to split into several patches, but that does not > really affect the review work. > > The original driver failed to initialize under a loaded CAN bus, on my > desk. The current driver is more cleanly written than the original > and it seems to survive more than 1 use case (although I have a MAB overflow > report pending to investigate). > So, this is a good candidate for mainline. > I just saw that you've pushed these patches to your testing branch. Does this mean that you're going to include it in v5.10 PR? Thanks, Mani > Kind regards, > Kurt
