On Tue, Sep 15, 2020 at 02:54:26AM +0200, Marek Behún wrote: > There is a bug in the device tree binding for cznic,turris-omnia-leds > which causes make dt_binding_check to complain. > > The reason is that the multi-led property binding's regular expression > does not contain the `@` character, while the example nodes do. > > Fix this, and also allow for longer address in property name. > > Signed-off-by: Marek Behún <marek.behun@xxxxxx> > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > Cc: devicetree@xxxxxxxxxxxxxxx > Cc: Pavel Machek <pavel@xxxxxx> > --- > .../devicetree/bindings/leds/cznic,turris-omnia-leds.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml b/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml > index 24ad1446445ea..486ab27d75f2f 100644 > --- a/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml > +++ b/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml > @@ -30,7 +30,7 @@ properties: > const: 0 > > patternProperties: > - "^multi-led[0-9a-f]$": > + "^multi-led@[0-9a-f]+$": There are only 12 LEDs on the device based on the description and 'reg', so 'b' is the max unit-address. I can fixup when applying: "^multi-led@[0-9a-b]$" > type: object > allOf: > - $ref: leds-class-multicolor.yaml# > -- > 2.26.2 >
