On Fri, Sep 04, 2020 at 08:22:53AM +0000, Wesley Cheng wrote: > Introduce the dt-binding for enabling USB type C orientation and role > detection using the PM8150B. The driver will be responsible for receiving > the interrupt at a state change on the CC lines, reading the > orientation/role, and communicating this information to the remote > clients, which can include a role switch node and a type C switch. > > Signed-off-by: Wesley Cheng <wcheng@xxxxxxxxxxxxxx> > --- > .../bindings/usb/qcom,pmic-typec.yaml | 108 ++++++++++++++++++ > 1 file changed, 108 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml Please see this thread[1]. Looks like similar functions and hence the bindings should be similar. There's a lot of USB Type C binding changes in flight. I'm just going to reject them all if folks that know the h/w and USB Type C better than me can't work together. > > diff --git a/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml b/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml > new file mode 100644 > index 000000000000..8582ab6a3cc4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml > @@ -0,0 +1,108 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/usb/qcom,pmic-typec.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Qualcomm PMIC based USB type C Detection Driver > + > +maintainers: > + - Wesley Cheng <wcheng@xxxxxxxxxxxxxx> > + > +description: | > + Qualcomm PMIC Type C Detect > + > +properties: > + compatible: > + enum: > + - qcom,pm8150b-usb-typec > + > + reg: > + maxItems: 1 > + description: Type C base address > + > + interrupts: > + maxItems: 1 > + description: CC change interrupt from PMIC > + > + connector: > + $ref: /connector/usb-connector.yaml# > + description: Connector type for remote endpoints > + type: object > + > + properties: > + compatible: > + enum: > + - usb-c-connector > + > + power-role: true > + data-role: true > + > + ports: > + description: Remote endpoint connections > + type: object > + > + properties: > + port@1: > + description: Remote endpoints for the Super Speed path > + type: object > + > + properties: > + endpoint@0: > + description: Connection to USB type C mux node > + type: object > + > + endpoint@1: > + description: Connection to role switch node > + type: object Not sure about this. The connector SS signals are routed to a mux and the above are the 2 choices? Rob [1] https://lore.kernel.org/linux-usb/TYBPR01MB53096D5A92B7AA149E5803D786260@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/