Hi Rob, On 02/09/20 1:07 pm, Kishon Vijay Abraham I wrote: > Hi Rob, > > On 02/09/20 10:24 am, Kishon Vijay Abraham I wrote: >> Hi Nishanth, >> >> On 01/09/20 8:22 pm, Nishanth Menon wrote: >>> On 19:36-20200901, Kishon Vijay Abraham I wrote: >>>> Add PCIe device tree node (both RC and EP) for the four >>>> PCIe instances here. >>>> >>>> Signed-off-by: Kishon Vijay Abraham I <kishon@xxxxxx> >>>> --- >>>> arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 218 >>>> ++++++++++++++++++++++ >>>> arch/arm64/boot/dts/ti/k3-j721e.dtsi | 5 +- >>>> 2 files changed, 222 insertions(+), 1 deletion(-) >>> >>> >>> Did you look at the diff of the dtbs_check before and after this >>> series? I see: https://pastebin.ubuntu.com/p/9fyfrTjx9M/ >> >> I didn't see any errors when I checked for individual bindings >> a0393678@a0393678-ssd:~/repos/linux$ mkconfig64 dtbs_check >> DT_SCHEMA_FILES="Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml" >> >> SCHEMA Documentation/devicetree/bindings/processed-schema.yaml >> DTC arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml >> DTC arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml >> CHECK arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml >> CHECK arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml >> a0393678@a0393678-ssd:~/repos/linux$ mkconfig64 dtbs_check >> DT_SCHEMA_FILES="Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml" >> >> SCHEMA Documentation/devicetree/bindings/processed-schema.yamlsimple-bus >> DTC arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml >> DTC arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml >> CHECK arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml >> CHECK arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml > > Can you give hint on why I get ranges is too long error > https://pastebin.ubuntu.com/p/cPm2tg3dcV/ which I give mkconfig64 > dtbs_check but don't see an error when I include "DT_SCHEMA_FILES"? I debugged this and looks like PCIe "ranges" property conflicts with simple-bus. A diff like below helps to solve the issue diff --git a/schemas/simple-bus.yaml b/schemas/simple-bus.yaml index 248ac9d..ed818ef 100644 --- a/schemas/simple-bus.yaml +++ b/schemas/simple-bus.yaml @@ -39,7 +39,7 @@ patternProperties: oneOf: - items: minItems: 3 - maxItems: 6 + maxItems: 7 minItems: 0 maxItems: 1024 - $ref: "types.yaml#/definitions/flag" If this looks right to you, I can post a patch for it. Without fixing this we would see false errors for PCIe DT nodes. Thanks Kishon
