On Fri, 2020-09-11 at 16:47 -0600, Rob Herring wrote: > On Thu, 10 Sep 2020 14:11:12 +0800, Chuanjia Liu wrote: > > Split the PCIe node and add pciecfg node to fix MSI issue. > > > > Acked-by: Ryder Lee <ryder.lee@xxxxxxxxxxxx> > > Signed-off-by: Chuanjia Liu <chuanjia.liu@xxxxxxxxxxxx> > > --- > > .../bindings/pci/mediatek-pcie-cfg.yaml | 38 +++++ > > .../devicetree/bindings/pci/mediatek-pcie.txt | 144 +++++++++++------- > > 2 files changed, 129 insertions(+), 53 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/pci/mediatek-pcie-cfg.yaml > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pci/mediatek-pcie-cfg.example.dt.yaml: example-0: pciecfg@1a140000:reg:0: [0, 437518336, 0, 4096] is too long > From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yaml > > > See https://patchwork.ozlabs.org/patch/1361249 > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure dt-schema is up to date: > > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade > > Please check and re-submit. > Thanks for your review, I will update my dt-schema and fix it in next version. regards, Chuanjia
