On Mon, Sep 7, 2020 at 11:17 PM Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx> wrote: > Per the datasheet the i2c functions use MPP_Sel=0x1. They are documented > as using MPP_Sel=0x4 as well but mixing 0x1 and 0x4 is clearly wrong. On > the board tested 0x4 resulted in a non-functioning i2c bus so stick with > 0x1 which works. > > Fixes: d7ae8f8dee7f ("pinctrl: mvebu: pinctrl driver for 98DX3236 SoC") > Signed-off-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx> > Reviewed-by: Andrew Lunn <andrew@xxxxxxx> This patch 1/3 applied for pin control fixes. Patches 2 & 3 should go via the SoC tree. Yours, Linus Walleij