> From: Peng Fan <peng.fan@xxxxxxx> > Sent: Friday, September 11, 2020 11:31 AM > > Add i.MX7ULP Power Management Controller binding doc > > Signed-off-by: Peng Fan <peng.fan@xxxxxxx> > --- > .../bindings/arm/freescale/imx7ulp-pmc.yaml | 33 +++++++++++++++++++ > 1 file changed, 33 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/arm/freescale/imx7ulp-pmc.yaml I wonder if we can merge it into the exist imx7ulp pm binding doc. Documentation/devicetree/bindings/arm/freescale/fsl,imx7ulp-pm.yaml > > diff --git > a/Documentation/devicetree/bindings/arm/freescale/imx7ulp-pmc.yaml > b/Documentation/devicetree/bindings/arm/freescale/imx7ulp-pmc.yaml > new file mode 100644 > index 000000000000..33a31d87dd62 > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/freescale/imx7ulp-pmc.yaml > @@ -0,0 +1,33 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/freescale/imx7ulp-pmc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: i.MX7ULP Power Management Controller(PMC) Device Tree Bindings > + > +maintainers: > + - Peng Fan <peng.fan@xxxxxxx> > + > +properties: > + compatible: > + items: > + - enum: > + - fsl,imx7ulp-pmc-m4 > + - fsl,imx7ulp-pmc-a7 Can we change to the exist naming pattern which also align with HW reference manual? e.g. fsl,imx7ulp-pmc0 fsl,imx7ulp-pmc1 Aligned with: fsl,imx7ulp-smc1 fsl,imx7ulp-pcc2 fsl,imx7ulp-scg1 Regards Aisheng > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + pmc0: pmc-m4@410a1000 { > + compatible = "fsl,imx7ulp-pmc-m4"; > + reg = <0x410a1000 0x1000>; > + }; > -- > 2.28.0