Hi Jason,
On Thursday 12 June 2014 06:50 PM, Jason Cooper wrote:
> On Thu, Jun 12, 2014 at 05:23:19PM +0530, Sricharan R wrote:
>> From: Nishanth Menon <nm@xxxxxx>
>>
>> When the provided unused skip list entry is greater than max irqs
>> possible, we go to err3, but we fail to free register_offsets,
>> should have returned to err4 instead which ensures that allocated
>
> s/returned/jumped/
ok, will correct.
>
>> register_offsets are freed as well.
>>
>> Signed-off-by: Nishanth Menon <nm@xxxxxx>
>> ---
>> drivers/irqchip/irq-crossbar.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c
>> index 42a2e62..fea3e5d 100644
>> --- a/drivers/irqchip/irq-crossbar.c
>> +++ b/drivers/irqchip/irq-crossbar.c
>> @@ -225,7 +225,7 @@ static int __init crossbar_of_init(struct device_node *node,
>>
>> if (entry > max) {
>> pr_err("Invalid skip entry\n");
>> - goto err3;
>> + goto err4;
>
> This would be a good opportunity to reduce the possibility of future
> errors. Please consider renaming err{1,2,3,4} to something more
> recognizable while you are here.
>
Ok, this is done as a part of patch#13.
Regards,
Sricharan
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
