Re: [PATCH v2 1/2] ASoC: dt-bindings: audio-graph-card: switch to yaml base Documentation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Rob

Thank you for your feedback

> > diff --git a/Documentation/devicetree/bindings/sound/audio-graph-card.yaml b/Documentation/devicetree/bindings/sound/audio-graph-card.yaml
> > new file mode 100644
> > index 000000000000..60d7b1504128
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/audio-graph-card.yaml
> > @@ -0,0 +1,135 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/sound/audio-graph-card.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Audio Graph Card Driver Device Tree Bindings
> > +
> > +maintainers:
> > +  - Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
> > +
> > +definitions:
> 
> Please don't use 'definitions' unless really needed. There's only 1 
> reference to 'endpoint' and 'port' so you don't here.

If this was applied, all audio-graph-card user driver want to use it.

> > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > index 63996ab03521..5ada35ddac7e 100644
> > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > @@ -20,7 +20,7 @@ patternProperties:
> >    "^(keypad|m25p|max8952|max8997|max8998|mpmc),.*": true
> >    "^(pinctrl-single|#pinctrl-single|PowerPC),.*": true
> >    "^(pl022|pxa-mmc|rcar_sound|rotary-encoder|s5m8767|sdhci),.*": true
> > -  "^(simple-audio-card|st-plgpio|st-spics|ts),.*": true
> > +  "^(simple-audio-card|audio-graph-card|st-plgpio|st-spics|ts),.*": true
> 
> This isn't needed as we got rid of the silly 'audio-graph-card,' prefix.

Oops ?
silly "audio-graph-card,xxx" is needed, but was missing on this patch.
Will care about in v2.

Thank you for your help !!

Best regards
---
Kuninori Morimoto



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux