The crossbar_domain_map/unmap callbacks need not be called same number of times for a particular irq. But still use counting is not needed here, because unmap(irq) gets called when irq_desc(irq) is disposed. After this the irq is anyways unusable and have to mapped again. Adding the above kerneldoc for unmap callback clarity. Signed-off-by: Sricharan R <r.sricharan@xxxxxx> --- drivers/irqchip/irq-crossbar.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c index 5f3e75a..2a73a66 100644 --- a/drivers/irqchip/irq-crossbar.c +++ b/drivers/irqchip/irq-crossbar.c @@ -101,6 +101,16 @@ static int crossbar_domain_map(struct irq_domain *d, unsigned int irq, return 0; } +/** + * crossbar_domain_unmap - unmap a crossbar<->irq connection + * @d: domain of irq to unmap + * @irq: virq number + * + * The map/unmap callbacks need not be called same number of times for + * a particular irq. But still use counting is not needed here, because + * unmap(irq) gets called when irq_desc(irq) is disposed. After this the + * irq is anyways unusuable and have to be mapped again. + */ static void crossbar_domain_unmap(struct irq_domain *d, unsigned int irq) { irq_hw_number_t hw = irq_get_irq_data(irq)->hwirq; -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html