On Tue, 2020-09-08 at 16:59 +0200, Krzysztof Kozlowski wrote:
> GPIO_ACTIVE_x flags are not correct in the context of interrupt
> flags.
> These are simple defines so they could be used in DTS but they will
> not
> have the same meaning:
> 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE
> 2. GPIO_ACTIVE_LOW = 1 = IRQ_TYPE_EDGE_RISING
>
> Correct the interrupt flags, assuming the author of the code wanted
> some
> logical behavior behind the name "ACTIVE_xxx", this is:
> ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW
>
> Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
For BD70528:
Acked-By: Matti Vaittinen <matti.vaittinen@xxxxxxxxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/mfd/act8945a.txt | 2 +-
> Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml | 3 ++-
> Documentation/devicetree/bindings/mfd/rohm,bd70528-pmic.txt | 2 +-
> 3 files changed, 4 insertions(+), 3 deletions(-)
>
>
> diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd70528-
> pmic.txt b/Documentation/devicetree/bindings/mfd/rohm,bd70528-
> pmic.txt
> index c3c02ce73cde..386eec06cf08 100644
> --- a/Documentation/devicetree/bindings/mfd/rohm,bd70528-pmic.txt
> +++ b/Documentation/devicetree/bindings/mfd/rohm,bd70528-pmic.txt
> @@ -39,7 +39,7 @@ pmic: pmic@4b {
> compatible = "rohm,bd70528";
> reg = <0x4b>;
> interrupt-parent = <&gpio1>;
> - interrupts = <29 GPIO_ACTIVE_LOW>;
> + interrupts = <29 IRQ_TYPE_LEVEL_LOW>;
This is how it should have been from the beginning :) Thanks!
Br,
Matti
--
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland
SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND
~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
"non cogito me" dixit Rene Descarte, deinde evanescavit
(Thanks for the translation Simon)
