On 11 June 2014 20:13, Kevin Hilman <khilman@xxxxxxxxxx> wrote: > Ulf Hansson <ulf.hansson@xxxxxxxxxx> writes: > >> The dev_irq_safe configuration is redundant, genpd don't have any >> special treatmeant for handling it. Let's remove it. > > Why? > > The genpd core needs to handle irq_safe properly eventully (right now it > just doesn't call power_off/power_on callbacks, but that needs to be > implmenented. c.f commit 0aa2a22169) > > If we remove these flags from platforms, we're taking away information > that the platform maintainers have specified tha will be useful when > full support is avialble. For sure this is needed in _some_ form. But before we even figured out how to support irq_safe genpd's, why even bother to support a configuration for it? Currently I think it good enough to use the per device irq_safe option, and then let's see how handling of these devices evolves. Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html