> > +static const struct mtk_iommu_plat_data mt8167_data = { > > + .m4u_plat = M4U_MT8167, > > + .flags = HAS_4GB_MODE | RESET_AXI | HAS_LEGACY_IVRP_PADDR, > > The 4GB mode flow was improved at[1] which has just been applied. > > If you add 4gb_mode flag but don't have "mt8167-infracfg", the probe may > be failed. Looking back at the datasheet I don't think HAS_4GB_MODE should have been enabled for MT8167 anyway. I just removed it and retested the patch. I will fix it in v4. Thanks > [1] > https://lore.kernel.org/linux-iommu/20200904112117.GC16609@xxxxxxxxxx/T/#m613e9926735d07ad004fddbbcedaa50b5afacca1